chore: dictionary curation#3666
Conversation
+ACC +CBASP +Glu +MRS +rsFC +glutamate +pregenual +racemate +racemic
hippietrail
left a comment
There was a problem hiding this comment.
Some notes on the sort order of the dictionary being case sensitive and obscure/specialized words have a dedicated section.
| GI/JNV | ||
| GIF/NSg # file format | ||
| GIGO/ | ||
| Glu/N # symbol for glutamate (anion of glutamic acid) |
There was a problem hiding this comment.
This section is for all-uppercase. It sounds silly but when I tried to re-sort in a case insensitive ordering it revealed a latent bug where order of words in the dictionary makes a difference and made passing tests fail. A PR covering all aspects of case problems in the dictionary is being worked on.
| Mozart/NOg | ||
| Mozilla/g # company | ||
| Mr/NSg | ||
| MRS/N # magnetic resonance spectroscopy |
There was a problem hiding this comment.
Same here. Easiest way to get them in the right spot is to turn on case sensitive search on your editor. Around line 6267 is where you want to look.
| PET/NOg # early computer | ||
| PFC/N | ||
| PG/JNO | ||
| pgACC/N # pregenual anterior cingulate cortex |
There was a problem hiding this comment.
Some of these look very specialized. The top/main part of the dictionary is for regular words. Specialized words are in a separate section so that they'll be easy to find if and when we decide to split them out into focussed Weir Packs. The specalized section starts around line 53,834 and 54,573 or so should be where a word starting with lowercase pg should go.
7a175c2 to
eb7b8c1
Compare
hippietrail
left a comment
There was a problem hiding this comment.
Looks good. Just one more to move. Thanks.
eb7b8c1 to
d11a85a
Compare
|
You've got failing "snapshot" tests. Your new words probably change the top 3 spelling suggestions for other unknown words in the old texts we test against. The way to fix this is to run |
Issues
N/A
Description
This is my first time trying to commit words to Harper. Any help and criticism is highly appreciated. I am neither an expert in linguistics nor a native English speaker, just someone who would like to help by adding words I frequently use in my research!
+ACC
+CBASP
+Glu
+MRS
+rsFC
+glutamate
+pregenual
+racemate
+racemic
How Has This Been Tested?
cargo testAI Disclosure
Checklist